[IMP] accounting: fiscal position update #4151
Conversation
chiaraprattico
force-pushed
the
16.0-fiscalposition-chpr
branch
5 times, most recently
from
9e35142 to
0a5862a
Compare
chiaraprattico
requested review from
LoredanaLrpz
and removed request for
a team
chiaraprattico
force-pushed
the
16.0-fiscalposition-chpr
branch
2 times, most recently
from
bab6030 to
3439dd5
Compare
LoredanaLrpz
left a comment
LoredanaLrpz
left a comment
There was a problem hiding this comment.
hey, hey @chiaraprattico , great job on this doc!
We'll see together tomorrow, but here's my review.
I suggest changing the structure a bit because of the application h2; here's what I suggest
h1: same
h2: same
h3: same
h2: Application
h3: Automatic application
h3: Manual application
h3: Apply to a partner
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
| The mapping of taxes and accounts is based on the default taxes and accounts defined in the | ||
| products' forms. |
There was a problem hiding this comment.
I think since there're three different types of taxes on products forms, it could be useful to specify the name of the field on which the mappings are based (I guess it is 'Customer Taxes" ?)
(+ add link to http://runbot175.odoo.com/runbot/static/build/30450745-16-0/logs/build/html/applications/finance/accounting/taxation/taxes/B2B_B2C.html or http://runbot175.odoo.com/runbot/static/build/30450745-16-0/logs/build/html/applications/finance/accounting/taxation/taxes/default_taxes.html ?)
There was a problem hiding this comment.
Soo, I'm not 100% sure I get your comment. A link can indeed be added regarding the info on taxes in product forms though I checked, and there is no good doc that directly refers to the product form. The two you put are related to general taxes but not in product form.
For when you say there are three types, there is only one "customer taxes", you only see the two others because the localization is American.
So I'll look again for a nice link to add but I think the rest is not necessary.
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
chiaraprattico
force-pushed
the
16.0-fiscalposition-chpr
branch
from
3439dd5 to
0916ac7
Compare
chiaraprattico
force-pushed
the
16.0-fiscalposition-chpr
branch
from
0916ac7 to
c220d93
Compare
LoredanaLrpz
left a comment
LoredanaLrpz
left a comment
There was a problem hiding this comment.
Hey @chiaraprattico; great page, I've approved, but there's one "a" missing. Other than that, it's all good.
Could you ping Be-doc once this small change is made?
content/applications/finance/accounting/taxation/taxes/fiscal_positions.rst
Outdated
Show resolved
Hide resolved
chiaraprattico
force-pushed
the
16.0-fiscalposition-chpr
branch
from
c220d93 to
a080417
Compare
xpl-odoo
force-pushed
the
16.0-fiscalposition-chpr
branch
from
a080417 to
65a8675
Compare
|
@chiaraprattico I pushed some changes to finalize the PR. However, could you add how different "types" of fiscal positions interact? e.g. if you have a fiscal position set on a partner and a fiscal position set to "detect automatically", which one takes precedence over the other? |
chiaraprattico
force-pushed
the
16.0-fiscalposition-chpr
branch
from
65a8675 to
f64b4e9
Compare
|
Hello @xpl-odoo , indeed it can be helpful so I ended up adding it. Though I feel like explaining it makes it seem more complex than it actually is. Let me know what you think and if we can work on another formulation. |
xpl-odoo
force-pushed
the
16.0-fiscalposition-chpr
branch
from
f64b4e9 to
b2f3af6
Compare
task-3272939
xpl-odoo
force-pushed
the
16.0-fiscalposition-chpr
branch
from
b2f3af6 to
1c3658e
Compare
|
@robodoo r+ |
4 participants
task-3272939